Provide distro specific url for help with system-upgrade (RhBug:1747408) #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
reviewed
Oct 7, 2019
plugins/system_upgrade.py
Outdated
| for line in release_file: | ||
| line = line.strip() | ||
| if line.startswith(key): | ||
| return line.lstrip(key + '"').rstrip('"') |
There was a problem hiding this comment.
Note that lstrip takes a set of characters, not a prefix to be removed.
>>> "DOCUMENTATION_URL=ABC".lstrip('"DOCUMENTATION_URL=')
'BC'
5e870bb to
4a24c2b
Compare
Os-release will provide the new key with url with help for system-upgrade. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1747408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Os-release will provide the new key with url with help for
system-upgrade.
https://bugzilla.redhat.com/show_bug.cgi?id=1747408