Embed words file and add go.mod file #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the typo binary self-contained and work properly when built from a repo cloned outside a GOPATH (as is the norm these days).
robpike
reviewed
Nov 15, 2022
| @@ -17,40 +19,37 @@ | |||
| // | |||
| // See the comments in the source for a description of the algorithm, extracted | |||
| // from Bell Labs CSTR 18 by Robert Morris and Lorinda L. Cherry. | |||
| // | |||
There was a problem hiding this comment.
This is what gofmt does today.
| @@ -4,7 +4,9 @@ | |||
|
|
|||
| // Typo is a modern version of the original Unix typo command, a scan of whose man page | |||
| // is at | |||
| // https://github.com/robpike/typo/blob/master/typo.png | |||
| // | |||
There was a problem hiding this comment.
really? one before and two after? well, if this is gofmt output, ok.
There was a problem hiding this comment.
I don't make the rules. :)
robpike
approved these changes
Nov 15, 2022
| @@ -17,40 +19,37 @@ | |||
| // | |||
| // See the comments in the source for a description of the algorithm, extracted | |||
| // from Bell Labs CSTR 18 by Robert Morris and Lorinda L. Cherry. | |||
| // | |||
| @@ -4,7 +4,9 @@ | |||
|
|
|||
| // Typo is a modern version of the original Unix typo command, a scan of whose man page | |||
| // is at | |||
| // https://github.com/robpike/typo/blob/master/typo.png | |||
| // | |||
There was a problem hiding this comment.
really? one before and two after? well, if this is gofmt output, ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of modernizations.