Skip to content

Fix resource import so generate_groundtruth works #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 1, 2025
Merged

Fix resource import so generate_groundtruth works #774

merged 5 commits into from
Apr 1, 2025

Conversation

nvrohanv
Copy link
Contributor

generate_groundtruth/__main__.py was importing DeviceResources directly from pylibraft. However generate_groundtruth attempts to call cuvs brute_force build which expects to get cuvs.common.Resources. This mismatch was causing the groundtruth generation script to crash. This PR fixes this and imports cuvs.common.Resources

@nvrohanv nvrohanv requested a review from a team as a code owner March 17, 2025 23:50
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 17, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@nvrohanv nvrohanv closed this Mar 17, 2025
@nvrohanv nvrohanv reopened this Mar 17, 2025
@bkarsin bkarsin added bug Something isn't working non-breaking Introduces a non-breaking change labels Mar 20, 2025
@gforsyth
Copy link
Contributor

/ok to test

@nvrohanv
Copy link
Contributor Author

/ok to test

1 similar comment
@gforsyth
Copy link
Contributor

/ok to test

tfeher
tfeher approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nvrohanv for the fix, LGTM!

@tfeher tfeher changed the title Fix resource import so generate_groundtruth works [REVIEW] Fix resource import so generate_groundtruth works Apr 1, 2025
@tfeher
Copy link
Contributor

tfeher commented Apr 1, 2025

/merge

@rapids-bot rapids-bot bot merged commit d77c73a into rapidsai:branch-25.04 Apr 1, 2025
62 checks passed
@nvrohanv nvrohanv deleted the rohanv/bug/fix-generate-groundtruth branch April 15, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfeher tfeher tfeher approved these changes

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Introduces a non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nvrohanv @gforsyth @tfeher @divyegala @bkarsin