feat(libcuvs): port libcuvs to rattler-build #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add source and fix nccl spec Add pre-build stage, remove static output, add tests and examples fix(libcuvs): handle most overlinking errors fix(libcuvs): install cuvs, c_api, and hnswlib components feat(libcuvs): remove defunct build scripts
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
This reverts commit b597650.
|
/ok to test |
|
/ok to test |
This reverts commit 2eb7ddd.
gforsyth
commented
Mar 10, 2025
bdice
reviewed
Mar 12, 2025
gforsyth
commented
Mar 12, 2025
|
This is ready for another look @bdice |
43 tasks
bdice
approved these changes
Mar 19, 2025
| then: | ||
| - libaio | ||
| - libboost-devel=1.87 | ||
| - mkl-devel=2023 |
There was a problem hiding this comment.
For follow-up: Why is this pinned to mkl 2023? The latest is 2025.0.1. https://anaconda.org/conda-forge/mkl/files
vyasr
approved these changes
Mar 19, 2025
Comment on lines
+24
to
+30
| # Remove `-fdebug-prefix-map` line from CFLAGS and CXXFLAGS so the | ||
| # incrementing version number in the compile line doesn't break the | ||
| # cache | ||
| set -x | ||
| export CFLAGS=$(echo $CFLAGS | sed -E 's@\-fdebug\-prefix\-map[^ ]*@@g') | ||
| export CXXFLAGS=$(echo $CXXFLAGS | sed -E 's@\-fdebug\-prefix\-map[^ ]*@@g') | ||
| set +x |
There was a problem hiding this comment.
Suggestion: rapidsai/rapids-cmake#798 (comment)
There was a problem hiding this comment.
Future suggestion: rather than maintaining separate cuvs-bench and cuvs-bench-cpu recipes, we should parametrize the recipe. The two should be almost identical.
|
/merge |
|
Followups recorded in rapidsai/build-planning#47 (comment) |
divyegala
pushed a commit
to divyegala/cuvs
that referenced
this pull request
Mar 21, 2025
This PR ports cuVS over to `rattler-build` for building conda packages. Some changes to the build process: * `cuvs-bench` was recompiling the entire library separately -- caching was hopefully helping with this but it was an unnecessary double-compile. Instead, I've added the `bench-ann` to the pre-build stage in `libcuvs` and create a `libcuvs-bench` output there, that `cuvs-bench` then depends on to provide the necessary shared objects. * Edited `build.sh` so that if `-n` is passed, the `cuvs-bench` Python package is not installed. * `libcuvs-static` seems to be a leftover from a previous incarnation -- the existing `libcuvs-static` packages on `rapidsai-nightly` consist only of build metadata files and are otherwise empty. I've removed the unused `--compile-static-lib` option from `build.sh` Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: rapidsai#751
jiangyinzuo
pushed a commit
to jiangyinzuo/cuvs
that referenced
this pull request
Mar 27, 2025
This PR ports cuVS over to `rattler-build` for building conda packages. Some changes to the build process: * `cuvs-bench` was recompiling the entire library separately -- caching was hopefully helping with this but it was an unnecessary double-compile. Instead, I've added the `bench-ann` to the pre-build stage in `libcuvs` and create a `libcuvs-bench` output there, that `cuvs-bench` then depends on to provide the necessary shared objects. * Edited `build.sh` so that if `-n` is passed, the `cuvs-bench` Python package is not installed. * `libcuvs-static` seems to be a leftover from a previous incarnation -- the existing `libcuvs-static` packages on `rapidsai-nightly` consist only of build metadata files and are otherwise empty. I've removed the unused `--compile-static-lib` option from `build.sh` Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: rapidsai#751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports cuVS over to
rattler-buildfor building conda packages.Some changes to the build process:
cuvs-benchwas recompiling the entire library separately -- caching was hopefully helping with this but it was an unnecessary double-compile. Instead, I've added thebench-annto the pre-build stage inlibcuvsand create alibcuvs-benchoutput there, thatcuvs-benchthen depends on to provide the necessary shared objects.Edited
build.shso that if-nis passed, thecuvs-benchPython package is not installed.libcuvs-staticseems to be a leftover from a previous incarnation -- the existinglibcuvs-staticpackages onrapidsai-nightlyconsist only of build metadata files and are otherwise empty. I've removed the unused--compile-static-liboption frombuild.sh