Don't use private APIs in FIL notebook #6488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this notebook used a couple internal `cuml` APIs. This PR switches them for public APIs instead.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
betatim
approved these changes
Mar 25, 2025
There was a problem hiding this comment.
LGTM
Only thought is: is recommending conda the thing to do or should it somehow be "use conda or pip, what ever applies to you dear user"? I'm thinking of things like "people try this on colab" where you shouldn't run conda. But maybe this is anyway too complicated a situation for us to address in an error message -> let's stick with conda?
|
No strong thoughts, it's not clear to me where or how a user might stumble upon this notebook or end up running it. Slight preference to do no more work here, IMO good enough for now. |
|
/merge |
csadorf
reviewed
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this notebook used a couple internal
cumlAPIs. This PR switches them for public APIs instead.