CI: Run extended accel mode tests #6377
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
1 similar comment
|
/ok to test |
9dee6aa to
882fcef
Compare
|
/ok to test |
882fcef to
2d6df62
Compare
273ee11 to
ae86706
Compare
|
The scikit-learn test suite takes about 30-45mins to complete. The job log is about 30MB long (~250k lines). We have a pass rate of about 88%. That's less than I had measured before, will have to investigate the cause for that. I am going to set the required pass rate at 80% for now. @bdice This is ready for review. |
…g for test patterns
…-learn tests. Update related test scripts and documentation to reflect these changes, simplifying the test execution process.
c63c3b8 to
32a2a33
Compare
| - `build.sh` | ||
| Clones and builds the scikit-learn repository. | ||
| Options: | ||
| - `--scikit-learn-version` : Specify the scikit-learn version to test (default: 1.5.2) |
There was a problem hiding this comment.
I would avoid hardcoded versions in this README. It's easy for these things to slip out of date.
ci/accel/scikit-learn-tests/build.sh
Outdated
|
|
||
| set -eu | ||
|
|
||
| SCIKIT_LEARN_VERSION="${SCIKIT_LEARN_VERSION:-1.5.2}" |
There was a problem hiding this comment.
I think a more natural default would be main, and then pin to 1.5.2 where this script is called (rather than hardcoding the version in this script itself).
ci/accel/scikit-learn-tests/build.sh
Outdated
| git clone --depth 1 https://github.com/scikit-learn/scikit-learn.git ${SCIKIT_LEARN_SRC_PATH} | ||
| fi | ||
|
|
||
| cd ${SCIKIT_LEARN_SRC_PATH} |
There was a problem hiding this comment.
Suggestion: Often in RAPIDS we use pushd and popd instead of cd so that CI scripts are a little more composable / less stateful.
|
/merge |
No description provided.