-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Include Ruby 3.1 #68
Conversation
MiniTest has released.
3,1 seems to be failing. |
Looks a bit like a Gemfile can solve this:
|
This is to avoid install failures for too-old Nokogiri versions on Ruby 3.1. Example error: nokogiri-1.12.5-x86_64-linux requires ruby version < 3.1.dev, >= 2.5, which is incompatible with the current version, ruby 3.1.1p18
@dhh I guess this small Gemfile.lock update does the trick. |
Now the failure is something else. |
This release perhaps includes this fix: rails/rails#43998
Alright! ruby-head is just not going to work yet.
|
"3 successful and 1 failing checks", isn't head supposed to just warn rather than block? |
@dhh I have unsuccessfully looked for an "allow failures" analogue in GH Actions. |
If not, maybe just remove head for now 👍 |
Nokogiri supports a Ruby version range that does not currently include ruby-head. Removing it from the matrix.
@dhh Perhaps this can be squashed on merge? |
MiniTest has released. https://rubygems.org/gems/minitest/versions/5.15.0 Any Ruby < 4.0.
This PR adds
backRubyhead
and3.1
.