Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Include Ruby 3.1 #68

Merged
merged 5 commits into from
Feb 22, 2022
Merged

CI: Include Ruby 3.1 #68

merged 5 commits into from
Feb 22, 2022

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Feb 15, 2022

MiniTest has released. https://rubygems.org/gems/minitest/versions/5.15.0 Any Ruby < 4.0.

This PR adds back head and Ruby 3.1.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
MiniTest has released.
@dhh
Copy link
Member

dhh commented Feb 19, 2022

3,1 seems to be failing.

@olleolleolle
Copy link
Contributor Author

Looks a bit like a Gemfile can solve this:

Fetching gem metadata from https://rubygems.org/..........
  nokogiri-1.12.5-x86_64-linux requires ruby version < 3.1.dev, >= 2.5, which is
  incompatible with the current version, ruby 3.1.1p18
  Took   2.70 seconds

This is to avoid install failures for too-old Nokogiri versions on Ruby
3.1.

Example error:
    nokogiri-1.12.5-x86_64-linux requires ruby version < 3.1.dev, >= 2.5, which is
  incompatible with the current version, ruby 3.1.1p18
@olleolleolle
Copy link
Contributor Author

@dhh I guess this small Gemfile.lock update does the trick.

@dhh
Copy link
Member

dhh commented Feb 22, 2022

Now the failure is something else.

@olleolleolle
Copy link
Contributor Author

olleolleolle commented Feb 22, 2022

Alright! ruby-head is just not going to work yet.

nokogiri-1.13.3-x86_64-linux requires ruby version < 3.2.dev, >= 2.6, which is
incompatible with the current version, ruby 3.2.0p-1

@dhh
Copy link
Member

dhh commented Feb 22, 2022

"3 successful and 1 failing checks", isn't head supposed to just warn rather than block?

@olleolleolle
Copy link
Contributor Author

@dhh I have unsuccessfully looked for an "allow failures" analogue in GH Actions.

@dhh
Copy link
Member

dhh commented Feb 22, 2022

If not, maybe just remove head for now 👍

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Nokogiri supports a Ruby version range that does not currently include ruby-head. Removing it from the matrix.
@olleolleolle olleolleolle changed the title CI: Include Ruby 3.1, ruby-head CI: Include Ruby 3.1 Feb 22, 2022
@olleolleolle
Copy link
Contributor Author

@dhh Perhaps this can be squashed on merge?

@dhh dhh merged commit 2915c52 into rails:main Feb 22, 2022
@olleolleolle olleolleolle deleted the patch-1 branch February 22, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants