Skip to content

Make license auto-detectable by GitHub #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Conversation

di
Copy link
Member

@di di commented Jul 6, 2022

This aligns wheel's license with GitHub's MIT license template and moves it to a filename that GitHub supports so GitHub is able to auto-detect this repository as having a MIT license.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #459 (86ba13e) into main (9d4264d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   67.57%   67.57%           
=======================================
  Files          12       12           
  Lines         916      916           
=======================================
  Hits          619      619           
  Misses        297      297           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4264d...86ba13e. Read the comment docs.

@SpecLad
Copy link

SpecLad commented Jul 27, 2022

FWIW, I think GitHub can locate the license at its current filename, since if you open https://github.com/pypa/wheel, there's a "View license" link in the sidebar. It just needs to be aligned with the template.

@agronholm
Copy link
Contributor

FWIW, I think GitHub can locate the license at its current filename, since if you open https://github.com/pypa/wheel, there's a "View license" link in the sidebar. It just needs to be aligned with the template.

I concur. Pip uses the same file name for the license. So @di , please change the file name back to the original one. I'm willing to merge this then.

@SpecLad
Copy link

SpecLad commented Jul 27, 2022

Also, the only lines that need to be corrected are the first two ("MIT License" and "Copyright"). The tool GitHub uses to detect licenses (licensee) ignores whitespace, so reformatting the paragraphs is unnecessary.

@di
Copy link
Member Author

di commented Jul 27, 2022

Done, thanks @SpecLad!

@agronholm agronholm merged commit 5edc61d into pypa:main Jul 27, 2022
@agronholm
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants