Skip to content

chore: various initial setup #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 2, 2022
Merged

chore: various initial setup #1

merged 5 commits into from
Feb 2, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Feb 2, 2022

No description provided.

@OrKoN OrKoN requested a review from mathiasbynens February 2, 2022 07:55
@OrKoN OrKoN changed the title chore: various initial setuo chore: various initial setup Feb 2, 2022
@mathiasbynens
Copy link
Member

wolflows 🤔

@OrKoN
Copy link
Collaborator Author

OrKoN commented Feb 2, 2022

Fixed 😂

@mathiasbynens
Copy link
Member

What’s the rationale for including package-log.json? If we’re gonna do this we should add an .npmrc with package-lock=true in it, so that it’s still updated even on systems where the global .npmrc disables it.

Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % question

@OrKoN
Copy link
Collaborator Author

OrKoN commented Feb 2, 2022

That is a recommendation from ossf/scorecard-action for pinned-dependencies:

If the package manager supports lock files (e.g. package-lock.json for npm), make sure to check these in the source code as well. These files maintain signatures for the entire dependency tree and saves from future exploitation in case the package is compromised.

Also, NPM recommends checking it in. I will add an .npmrc.

@OrKoN OrKoN merged commit 6f3cf78 into main Feb 2, 2022
@OrKoN OrKoN deleted the chores branch February 2, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants