Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom filter model causes error when inside a column group #7069

Open
2 of 4 tasks
Emily-ejag opened this issue Jan 9, 2025 · 6 comments
Open
2 of 4 tasks

Custom filter model causes error when inside a column group #7069

Emily-ejag opened this issue Jan 9, 2025 · 6 comments
Labels
Resolution: Needs Upvote 👍 Support this idea or feature by adding an upvote. Community feedback helps with prioritization. Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add

Comments

@Emily-ejag
Copy link

Describe the bug

When the ColumnGroup type attribute is set on the columngroup, it is possible to filter using displayFilter: row. However, we need to use displayFilter: menu as our filters are slightly more complex. This is currently not working as of PrimeVue v4.2.4
image

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/vitejs-vite-m3gnvfyz?file=src%2FApp.vue

Environment

vite version 5.4.2

Vue version

3.2.25

PrimeVue version

4.2.4

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Create a DataTable
  2. Add Column Grouping to the data table
  3. Add a filter template to the data table
  4. On the ColumnGroup component tag add type="header"
  5. See the Grouping header disappear and not having any filter

Expected behavior

We expect having Column group and the menu filter on the group headers
image

@Emily-ejag Emily-ejag added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 9, 2025
@jo87jimmy
Copy link

I have the same problem

@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Resolution: Needs Upvote 👍 Support this idea or feature by adding an upvote. Community feedback helps with prioritization. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 20, 2025
Copy link

Thanks a lot for this issue! PrimeTek's own vision for PrimeVue is demanding, but community feedback is crucial in prioritization. The more upvotes help ensure this fix can be addressed quickly or the related PR can be merged soon.

@Emily-ejag
Copy link
Author

Emily-ejag commented Jan 21, 2025

This bug did not exist on version 3.43.0 @tugcekucukoglu @cagataycivici

@jyeatman
Copy link

I'm having the same issue

@mortlandj
Copy link

I'm having the same issue in upgrading from version 3.53.0 to version 4.25.0

@Emily-ejag
Copy link
Author

Hello @tugcekucukoglu & @cagataycivici,

Would it be possible to get an update on this issue? It has been open for over a month, and we'd appreciate any insights on its status.

Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs Upvote 👍 Support this idea or feature by adding an upvote. Community feedback helps with prioritization. Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

5 participants