Skip to content

Fix #71417: fread() does not report zlib.inflate errors #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix #71417: fread() does not report zlib.inflate errors #5408

wants to merge 2 commits into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Apr 17, 2020

If the zlib.inflate filter fails to decompress the stream, we raise a
notice instead of failing silently.

This is basically the same as PR #5406, but there has been a separate bug report.

@cmb69
Fix #71417: fread() does not report zlib.inflate errors
ee2b157 
If the zlib.inflate filter fails to decompress the stream, we raise a
notice instead of failing silently.
@nikic
Copy link
Member

nikic commented Apr 20, 2020

CI failure legit:

========DIFF========
003+ Notice: stream_filter_append(): zlib inflate failed in /home/travis/build/php/php-src/ext/standard/tests/filters/filter_errors.inc on line 24
004+ 
007+ 
008+ Notice: stream_get_contents(): zlib inflate failed in /home/travis/build/php/php-src/ext/standard/tests/filters/filter_errors.inc on line 34
========DONE========
FAIL Filter errors: zlib.inflate [ext/standard/tests/filters/filter_errors_zlib_inflate.phpt]

nikic
nikic reviewed Apr 20, 2020
View reviewed changes
@cmb69
Use zError() instead of generic error message
2f1d6bb 
We also fix failing test cases.
@cmb69
Copy link
Member Author

cmb69 commented Apr 20, 2020

Thanks! Applied as 3d1b730.

@cmb69 cmb69 closed this Apr 20, 2020
@cmb69 cmb69 deleted the cmb/71417 branch April 20, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmb69 @nikic