Skip to content

Implement full callable type signatures #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

nikita2206
Copy link
Contributor

@nikita2206 nikita2206 force-pushed the callable-typehint branch 2 times, most recently from 5c61978 to 37e2cf7 Compare November 12, 2015 09:16
@laruence laruence added the RFC label Nov 14, 2015
@nikita2206 nikita2206 force-pushed the callable-typehint branch 5 times, most recently from 47b30e4 to b6d0a75 Compare April 18, 2016 12:37
@nikita2206 nikita2206 force-pushed the callable-typehint branch from c42127b to 11fc3fe Compare May 19, 2016 19:14
@nikita2206 nikita2206 closed this Jul 7, 2016
@faizanakram99
Copy link

Can this be revisited / reopened ?

@nikita2206
Copy link
Contributor Author

@faizanakram99 looking at the PR probably doesn't make a lot of sense because a lot has changed in the PHP codebase since then. In general the feedback was that people didn't like the syntax of ad-hoc in-place type declarations, maybe this would fly with aliasing (ie if you had to declare function types like this type MyCallback = fn(Foo, Bar): int)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants