Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pbrisbin/bugsnag-haskell
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.2.2
Choose a base ref
...
head repository: pbrisbin/bugsnag-haskell
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.3.0
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Dec 3, 2018

  1. Move request header redacting 

    In the main notify routine, the before-notify composition places the
most local function (the one passed directly to notifyWith) last in the
change, after the one coming from Settings. To do otherwise could be
surprising.

Since updateEventFromWaiRequest is almost-certainly used as an argument
to notifyWith, it sets the Event Request /after/ the Settings hook has
run. Therefore, placing the header redaction as a default in Settings in
an effort to ensure it always runs was misguided: it has no effect.

This change moves the redaction into the before-notify dealing with the
WAI Request itself:

- There's not (currently) any other (endorsed) way to set the Event
  Request, so there's no need to redact /except/ in this function
- Doing it this way should ensure we don't mess up the ordering
- An Unredacted version was exported just in case that's useful

Fixes #31 for real.

NOTE: we really should have a way to put a regression test on this.
    @pbrisbin
    pbrisbin committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    c231d83 View commit details
    Browse the repository at this point in the history

  2. Version bump

    @pbrisbin
    pbrisbin committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    6dc6d06 View commit details
    Browse the repository at this point in the history
Loading