-
Notifications
You must be signed in to change notification settings - Fork 7
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: pbrisbin/bugsnag-haskell
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.1.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: pbrisbin/bugsnag-haskell
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.2.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 11 commits
- 20 files changed
- 1 contributor
Commits on Aug 6, 2018
-
Store a single Exception in the Event
This has been a source of great confusion for me. It makes no sense that the API accepts multiple Exceptions per Event, while at the same time: - Exception-specific properties (e.g. groupingHash) are Event-level - All client's have a setting like ignoreException, without really explaining how that might apply to the multi-Exception Event (do you ignore if they all match? Any? Do you filter, then ignore if empty?) Turns out, at least as far as I can tell, the multi-Exception interface is a Ruby-specific affordance. It's to support Exception#cause[1]. Even that library is oriented in a single-Exception way, then it attempts to unwrap nested Exceptions at report-time. If it finds many levels, it needs a way to include them all, so the interface for the API was bent to accept exceptions (rather than accept Exception.cause :: Exception, which would've been both *more* Ruby-inspired and, IMO, a better general interface!). [1]: https://github.com/bugsnag/bugsnag-ruby/blob/f8322960b5b2a9c7f9c60c2a68abddd9f24d5ec1/lib/bugsnag/report.rb#L174-L208 Haskell doesn't have this notion (at least, not in any kind of first-class way). So we can basically take the same approach: pretend the whole world is single-Exception, then wrap it up as a list at report-time only. The upside is we could avoid a documented caveat (updateException), an ErrorCall (bugsnagShouldNotify), and we should now be able to resolve Issue #26. The downside is we needed a manual ToJSON instance to perform the translation. No big deal. We could've avoided even this by using some kind of newtype, but that would've made the value-construction/use more cumbersome, so a poor trade-off.
Configuration menu - View commit details
-
Copy full SHA for 8445615 - Browse repository at this point
Copy the full SHA 8445615View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09935e0 - Browse repository at this point
Copy the full SHA 09935e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4e14e7 - Browse repository at this point
Copy the full SHA f4e14e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8fadde - Browse repository at this point
Copy the full SHA f8faddeView commit details
Commits on Aug 22, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 41cb81a - Browse repository at this point
Copy the full SHA 41cb81aView commit details
Commits on Sep 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e58b86d - Browse repository at this point
Copy the full SHA e58b86dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bf251b - Browse repository at this point
Copy the full SHA 1bf251bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 120e60b - Browse repository at this point
Copy the full SHA 120e60bView commit details -
Glob < 0.9.0 returns absolute paths, which means lookups with relative keys fails if using that version.
Configuration menu - View commit details
-
Copy full SHA for 41ab94e - Browse repository at this point
Copy the full SHA 41ab94eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5f9654 - Browse repository at this point
Copy the full SHA e5f9654View commit details -
Configuration menu - View commit details
-
Copy full SHA for c61eb14 - Browse repository at this point
Copy the full SHA c61eb14View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.0.1.3...v0.0.2.0