-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network packet-capture #77
Add network packet-capture #77
Conversation
9f74b94
to
b832843
Compare
/assign @rogbas |
b832843
to
1feafea
Compare
1feafea
to
441f8c6
Compare
441f8c6
to
0b8abac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code looks good, I still have to build/test locally. Just a few small things we can discuss but nothing that should block this getting in.
/label tide/merge-method-squash |
Overall the change is looking good, I just added a question that not necessarily blocks merging this PR. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, rogbas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add network packet-capture to perform a priviledged node tcpdump. * Use timestamp in pcap filename and add 'pcap' alias * Throw error when DS with the same name exists * Change default packet capture DS name * Change image name to openshift-sre org * Change test function name * Make docs
This adds a new domain (
network
) and action: (packet-capture
) which runs a privileged tcpdump on nodes for a given duration (60s). After completion, will copy the .pcap files to the local directory (./capture-output/).Options:
Example run: