-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODC-7735: Edit ci tests to have step to enable developer perspective #14684
ODC-7735: Edit ci tests to have step to enable developer perspective #14684
Conversation
@sanketpathak: This pull request references ODC-7735 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sanketpathak: This pull request references ODC-7735 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@@ -19,7 +20,14 @@ before(() => { | |||
const bridgePasswordPassword: string = Cypress.env('BRIDGE_HTPASSWD_PASSWORD') || 'test'; | |||
cy.login(bridgePasswordIDP, bridgePasswordUsername, bridgePasswordPassword); | |||
cy.document().its('readyState').should('eq', 'complete'); | |||
cy.exec( | |||
`oc patch console.operator.openshift.io/cluster --type='merge' -p '{"spec":{"customization":{"perspectives":[{"id":"dev","visibility":{"state":"Enabled"}}]}}}'`, | |||
{ failOnNonZeroExit: false }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wouldn't we fail on non-zero codes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was used for the case that each package(ODC) will be using this patch so to avoid any issue I used this, I'll update it
cy.reload(); | ||
cy.document().its('readyState').should('eq', 'complete'); | ||
checkDeveloperPerspective(tries - 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably better just to wait for the rollout using CLI commands after the oc patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will find the rollout command and update the code
cy.exec( | ||
`oc patch console.operator.openshift.io/cluster --type='merge' -p '{"spec":{"customization":{"perspectives":[{"id":"dev","visibility":{"state":"Enabled"}}]}}}'`, | ||
{ failOnNonZeroExit: false }, | ||
); | ||
cy.reload(true); | ||
cy.document().its('readyState').should('eq', 'complete'); | ||
guidedTour.close(); | ||
checkDeveloperPerspective(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid duplicate code if we can (here and below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes these will be revamped based on your point here
@@ -19,7 +20,14 @@ before(() => { | |||
const bridgePasswordPassword: string = Cypress.env('BRIDGE_HTPASSWD_PASSWORD') || 'test'; | |||
cy.login(bridgePasswordIDP, bridgePasswordUsername, bridgePasswordPassword); | |||
cy.document().its('readyState').should('eq', 'complete'); | |||
cy.exec( | |||
`oc patch console.operator.openshift.io/cluster --type='merge' -p '{"spec":{"customization":{"perspectives":[{"id":"dev","visibility":{"state":"Enabled"}}]}}}'`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only a stop-gap until we are able to update the tests?
We should be running most tests with default configuration if possible. I'd only expect a handful of tests to check the dev perspective works when enabled and the other tests be updated to use the admin perspective nav items to get to the same pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was thinking of this pr as a stop-gap to unblock the pr openshift/console-operator#954 but as admin tests are also being updated I will update the tests to point to the admin side of things wherever it can be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sanketpathak. There are a lot of test changes happening for the PF6 upgrade as well, so we should coordinate to avoid conflicts. @jhadvig @rhamilto FYI
0268001
to
72901b1
Compare
72901b1
to
f59261f
Compare
@sanketpathak: This pull request references ODC-7735 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
8b0b1e1
to
3437be7
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lokanandaprabhu The frontend/packages/dev-console/integration-tests/support/pages/add-flow/catalog-page.ts |
/retest |
5 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/label px-approved |
c840b60
to
e53787d
Compare
6307e79
to
93b1aef
Compare
93b1aef
to
5019fff
Compare
/test backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lokanandaprabhu, sanketpathak, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label qe-approved |
@sanketpathak: This pull request references ODC-7735 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label acknowledge-critical-fixes-only |
@sanketpathak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-console |
Description:
Fixing CI tests for the pr openshift/console-operator#954 to run green on CI
Story:
Checks for approving Epic scenarios Automation PR:
Execution Commands:
Have a cluster and disable developer perspective in customization of console
Execute CI files in the following test packages:
Screenshots:
Browser conformance: