Skip to content

Feature/make installable #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 29, 2021

Conversation

boba-and-beer
Copy link
Contributor

I moved everything into modules to make it PIP Installable.
I currently have created a package which can be found here: https://pypi.org/project/clip-by-openai/.
This should make CLIP a lot easier to use for individuals looking to test it out. Furthermore, I have also added the model to VectorHub, an open-source repository for vector search models I maintain, which can be found here:
https://hub.getvectorai.com/model/text_image%2Fclip

The link may be useful for people looking for low barriers to entry when trying out CLIP.

@jongwook
Copy link
Collaborator

Hi, thanks for your interest in CLIP and packaging it for easier use.

We cannot merge this PR at this state because it has a few issues we'd like to fix, such as the overly complex .gitignore, unintended audience and supported Python versions in setup.py, recommendation of installing pytorch and cudatoolkit via PIP in README.md, and multiple references to your company.

We are actually working on an update to make this package PIP-installable, and we are planning to make it work this way:

pip install git+https://github.com/openai/CLIP.git

so that we don't have to worry about versioning for now.

Would you like me to make edits directly on this branch before merging this PR, or would you rather close this PR entirely?

@boba-and-beer
Copy link
Contributor Author

That's a good way to go about it. I would like you to make edits on this branch if possible. Would love to track how this goes and make whatever small contribution I can for CLIP. Found the paper and blog quite insightful and I'm surprised with the results! I have also removed all mentions of VectorAI from this PR.

@boba-and-beer
Copy link
Contributor Author

Closing for now.

@jongwook jongwook reopened this Jan 29, 2021
@jongwook jongwook merged commit 3bee281 into openai:main Jan 29, 2021
@jamt9000
Copy link
Contributor

jamt9000 commented Jan 31, 2021

@jongwook since it seems to work fine for pytorch 1.7 could you relax the requirements to

pytorch~=1.7
torchvision==0.8.*

so that pip install works? (torchvision from source ends up having version number 0.8.0a0 hence the *)

@haltakov
Copy link

@jongwook since it seems to work fine for pytorch 1.7 could you relax the requirements to

pytorch~=1.7
torchvision==0.8.*

so that pip install works? (torchvision from source ends up having version number 0.8.0a0 hence the *)

I did some experiments with torch==1.7.0 and it fails in very subtle ways. Most of the time everything seems fine, but there is some very strange behavior at other times. If you are interested I can create a small demo showing the behavior.

@jamt9000
Copy link
Contributor

@haltakov I see - yes it would be good to know how it fails

@brunodoamaral
Copy link

@haltakov I see - yes it would be good to know how it fails

See #13. I had the same strange behavior reported in this issue.

@haltakov
Copy link

haltakov commented Feb 1, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants