JANITORIAL: Fix spelling mistakes in comments and text #7593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and typo in imgui_widgets.cpp "sought" would be the correct spelling, but since it is meant as a followup to the command "seek", distinguishing it with an apostrophe is probably better than leaving it(?)
|
I merged this, thank you! |
|
where does upstream come from for the two files? |
|
https://github.com/nothings/stb/ but good luck getting typo fixes merged in (they are 8 open typos PR). |
|
ugh...132 open PRs...I better skip that then...thanks for the heads up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code or variables were touched, these are solely typo fixes in either text or comments.
"seeked" should be "sought", but i was told on another project that it is meant as a follow up and explanation to the command of "seek"ing in data, i think it would be best to distinguish it with an added apostrophe (seek'ed).
That way it won' t come up as error anymore and the meaning is still preserved.
I hope i didn't break any rules by simply adding a PR here