tweaks to not use celery AsyncResult and EagerResult for task status #89
Conversation
| operations = [ | ||
| migrations.AddField( | ||
| model_name='importtask', | ||
| name='task_status', |
There was a problem hiding this comment.
Can probably just be status, no need to repeat task here.
| SUCCESS = 'SUCCESS' | ||
| FAILURE = 'FAILURE' | ||
|
|
||
| READY_STATES = [SUCCESS, FAILURE] |
There was a problem hiding this comment.
Maybe FINAL_STATES here? Ready seems a bit ambiguous. Also why not use a single character here? Maybe change SUCCESS to COMPLETE so there isn't overlap with S
There was a problem hiding this comment.
Just realized you might be using these to keep compatibility with what the Celery states are. If so then that's fine.
There was a problem hiding this comment.
Right I got those from Celery even if it is not guaranteed that the will always be in sync.
Also for task_status I wanted to keep the status method for backward compatibility in case it was called by someone
There was a problem hiding this comment.
Ok, fair enough and a good reason. Looks good then, merge at will.
| STARTED = 'STARTED' | ||
| RUNNING = 'RUNNING' | ||
| SUCCESS = 'SUCCESS' | ||
| FAILURE = 'FAILURE' |
No description provided.