fix(js): allow publishable library to run release command #29775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit c085917.
☁️ Nx Cloud last updated this comment at |
dcfe278 to
ce3fe9e
Compare
a71555f to
0762eb6
Compare
fe594f1 to
0762eb6
Compare
leosvelperez
reviewed
Feb 5, 2025
JamesHenry
requested changes
Feb 5, 2025
3d0d1bd to
25b881e
Compare
leosvelperez
reviewed
Feb 6, 2025
25b881e to
1a874c9
Compare
37f3a20 to
0759294
Compare
0759294 to
506781d
Compare
leosvelperez
approved these changes
Feb 10, 2025
JamesHenry
reviewed
Feb 10, 2025
506781d to
c085917
Compare
JamesHenry
approved these changes
Feb 10, 2025
jaysoo
pushed a commit
that referenced
this pull request
Feb 12, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> - there is no option `fallbackCurrentVersionResolver: 'disk',` - can't run release for newly created publishable libraries ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> - move code to add release for publishable libraries into its own file to be reused by other stacks - add `fallbackCurrentVersionResolver: 'disk',` to project's release.version. generatorOptions ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #29723
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
fallbackCurrentVersionResolver: 'disk',Expected Behavior
fallbackCurrentVersionResolver: 'disk',to project's release.version. generatorOptionsRelated Issue(s)
Fixes #29723