Skip to content

fix: clarify the file name to be used #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

andrewnessinjim
Copy link
Contributor

As I was following the steps in this page - https://docs.npmjs.com/creating-node-js-modules, I noticed the following error when using the published package in the test-directory:

Error: Cannot find module 'D:\Learning\npm-docs\use-hello\node_modules\@andrewnessindev\hello\index.js'. Please verify that the package.json has a valid "main" entry

It turned out that I missed providing the main entry even though this page already mentions to provide it. However, it might be more helpful if the docs clarify which file is referred to when it says, "In the file".

This is my first commit! I followed the instruction it the contributing.md file for the commit message. I did not see a requirement to raise an issue first! Please do let me know if I have to raise an issue first or if I have missed anything else.

@wraithgar wraithgar merged commit 83807db into npm:main Jun 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants