Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to create public room without password if password_policy enabled #14209

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed
Siteproxy

Verified

This commit was signed with the committer’s verified signature.
a1994sc Allen Conlon
…enabled

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added 2. developing bug feature: api 🛠️ OCS API for conversations, chats and participants labels Jan 24, 2025
@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Jan 24, 2025
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it's broken and this change fixes it 👍

@Antreesy
Copy link
Contributor Author

We discussed internally, that password_policy might not be considered in CI tests (or it's only this specific case), so any help with covering it is appreciated

@Antreesy Antreesy marked this pull request as ready for review January 27, 2025 09:23
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but would be good to add a CI test for it.
We can do that in a follow up as well

@nickvergessen
Copy link
Member

/backport to stable31

@Antreesy Antreesy merged commit 2ed4009 into main Jan 27, 2025
77 checks passed
@Antreesy Antreesy deleted the fix/13944/empty-pasword-allow branch January 27, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing bug feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants