Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FilePreview): set fixed size to image container #13109

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 22, 2024

☑️ Resolves

  • Minor UX changes to FilePreview
    • fix container size to single source (prevents jumping to 0 and back when image is loaded)
    • use NcLoadingIcon
    • don't load virtual image in mounted hook
    • add fade transition from blurhash/loader to image

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before

before.mp4

🏡 After

after.mp4

🏁 Checklist

- this prevents jumping to 0 and back when image is loaded

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Aug 22, 2024
@Antreesy Antreesy requested review from ShGKme and DorraJaouad August 22, 2024 19:11
@Antreesy Antreesy self-assigned this Aug 22, 2024
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, looks good on screencast

@nickvergessen
Copy link
Member

/backport to stable30

@nickvergessen nickvergessen merged commit a679b16 into main Aug 23, 2024
46 checks passed
@nickvergessen nickvergessen deleted the fix/noid/stable-previews branch August 23, 2024 09:42
@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 23, 2024

Didn't test

Maybe we should 🙈

  • image container size is fixed to small square when loading:
    image

  • and when upload is failed:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants