Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set devMode in CallView component #13026

Merged
merged 4 commits into from
Aug 19, 2024
Merged

fix: set devMode in CallView component #13026

merged 4 commits into from
Aug 19, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image
image
image

🏁 Checklist

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Aug 17, 2024
@Antreesy Antreesy self-assigned this Aug 17, 2024
@Antreesy Antreesy requested review from DorraJaouad and ShGKme August 19, 2024 07:48
DorraJaouad
DorraJaouad reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good, thanks! Just two small notes:

src/components/CallView/CallView.vue Outdated Show resolved Hide resolved
src/components/CallView/Grid/Grid.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/noid/call-dev-mode branch from 5ae43ae to f0bcc9c Compare August 19, 2024 12:38
DorraJaouad
DorraJaouad reviewed Aug 19, 2024
View reviewed changes
src/components/CallView/Grid/Grid.vue Outdated Show resolved Hide resolved
src/components/CallView/Grid/Grid.vue Outdated Show resolved Hide resolved
DorraJaouad
DorraJaouad approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (+ lint fix)

@Antreesy Antreesy force-pushed the fix/noid/call-dev-mode branch from c7a1701 to 312297a Compare August 19, 2024 15:36
@Antreesy Antreesy enabled auto-merge August 19, 2024 15:38
@Antreesy Antreesy merged commit b2acc99 into main Aug 19, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/call-dev-mode branch August 19, 2024 15:48
@Antreesy
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Oct 14, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v21.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @ShGKme @DorraJaouad