Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get call peers by federated users #12962

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

danxuliu
Copy link
Member

Fixes #12936

Additionally:

  • it updates the ping of federated users when they join the host room for consistency with the behaviour for the rest of the participants (which is unrelated to Federated call ends after some time without a local participant #12917; there the problem is that the ping is not updated in the federated server) and because it is needed for the integration tests that depend on the ping and do not have a real external signaling server (in a real environment the external signaling server updated the ping of federated users in the host server)
  • it takes into account federated users when getting the actor id from the call peers in the WebUI, which is used to set the correct avatar and background (in case the actor id was not provided by signaling messages, which it should be).

Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed test looks a bit weird: https://github.com/nextcloud/spreed/actions/runs/10384972680/job/28753120055?pr=12962#step:15:3755 - 2 sessions?

Other than that, tested with iOS and works as advertised.

@nickvergessen
Copy link
Member

Failed test looks a bit weird: https://github.com/nextcloud/spreed/actions/runs/10384972680/job/28753120055?pr=12962#step:15:3755 - 2 sessions?

The test is about joining twice, so that is correct.
It just didn't fail so far as the first session never pinged, so it was ignored on returning. Now it's pinged when initially joining and no longer ignored.

Will adjust the expected result

@nickvergessen
Copy link
Member

/backport to stable30

This is consistent with the behaviour for the rest of participants, as
the ping is updated when a participant joins the room, and it will be
needed for proper behaviour of integration tests that require an updated
ping.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The call peer data is used by the iOS app to get information about the
peers in the call before the connection with the signaling server is
established, so the data can not be got from signaling messages and the
peer data endpoint should be available also in federated conversations.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
@nickvergessen nickvergessen force-pushed the get-call-peers-by-federated-users branch from 6ebba5c to 02cfb4e Compare August 15, 2024 07:18
@nickvergessen nickvergessen merged commit c8b9e8d into main Aug 15, 2024
67 checks passed
@nickvergessen nickvergessen deleted the get-call-peers-by-federated-users branch August 15, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support getPeersForCall for federated calls
4 participants