-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get call peers by federated users #12962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed test looks a bit weird: https://github.com/nextcloud/spreed/actions/runs/10384972680/job/28753120055?pr=12962#step:15:3755 - 2 sessions?
Other than that, tested with iOS and works as advertised.
The test is about joining twice, so that is correct. Will adjust the expected result |
/backport to stable30 |
This is consistent with the behaviour for the rest of participants, as the ping is updated when a participant joins the room, and it will be needed for proper behaviour of integration tests that require an updated ping. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The call peer data is used by the iOS app to get information about the peers in the call before the connection with the signaling server is established, so the data can not be got from signaling messages and the peer data endpoint should be available also in federated conversations. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
6ebba5c
to
02cfb4e
Compare
Signed-off-by: Joas Schilling <[email protected]>
Fixes #12936
Additionally: