Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conversations): Add new sample conversation "💡 Let's get started!" #14124

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 13, 2025

☑️ Resolves

Conv Details Chat
grafik grafik
Admin docs Bildschirmfoto vom 2025-01-14 13-54-23
Bildschirmfoto vom 2025-01-14 13-54-35

🛠️ API Checklist

🚧 Tasks

  • Admin config to disable
  • Allow reading a replacement file from an appconfig specified path that is posted instead
  • Notify mobile apps about the avatar rendering for guest/sample

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 2. developing enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Jan 13, 2025
@nickvergessen nickvergessen self-assigned this Jan 13, 2025
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just mentioning theming/branding here again. Not sure about mentioning the product name directly?
Also, should there be a setting to disable that, like the changelog config?

lib/Chat/Parser/Changelog.php Outdated Show resolved Hide resolved
lib/Service/SampleConversationsService.php Outdated Show resolved Hide resolved
lib/Service/SampleConversationsService.php Outdated Show resolved Hide resolved
@nickvergessen
Copy link
Member Author

Also, should there be a setting to disable that, like the changelog config?

See open todos

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great overview of what's possible :) Broad pieces of feedback:

  • The introduction to Talk seems a bit hidden in the conversation description, and jumping straight into the features feels a bit sudden, especially if I was a new user. I'd suggest adding a short description as the first section
  • "Manage conversation settings" being the first section seems rather technical, it could be the last one, with a more simple section like the "Format messages" section as the first one

Other than that, some wording changes:

  • "markdown syntax" --> "Markdown syntax" (capital M)
  • Smart picker section --> Simply type "/" or go to the "+" menu to open the Smart Picker where you can attach various content to your messages. You can configure the Smart Picker to be able to add items from Nextcloud apps, GIFs, map locations, AI generated content and much more.
  • Attachments section --> Attach files from your Nextcloud Hub using the "+" button. Share items from Files, Collectives, Tables, Deck and more. Some apps even support interactive widgets, for example, the Text app

$user->getUID()
);

$this->avatarService->setAvatarFromEmoji($room, '💡', '0082c9');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly we could use the set primary color as the background for "Note to self" and "Let's get started"? But no strong opinion here, as I see it as a part of the Nextcloud branding if it's too blue

lib/Service/SampleConversationsService.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the feat/14017/sample-conversations branch 4 times, most recently from 4246c95 to 4593dc0 Compare January 14, 2025 14:18
@nickvergessen nickvergessen added this to the 🌿 Next Beta (31) milestone Jan 14, 2025
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 🚀

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good

src/components/AvatarWrapper/AvatarWrapper.vue Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the feat/14017/sample-conversations branch from 4593dc0 to 0eaf74b Compare January 15, 2025 06:50
@nickvergessen nickvergessen force-pushed the feat/14017/sample-conversations branch from 0eaf74b to b396a2f Compare January 15, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New example conversation demoing various features
4 participants