-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conversations): Add new sample conversation "💡 Let's get started!" #14124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just mentioning theming/branding here again. Not sure about mentioning the product name directly?
Also, should there be a setting to disable that, like the changelog
config?
See open todos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Great overview of what's possible :) Broad pieces of feedback:
- The introduction to Talk seems a bit hidden in the conversation description, and jumping straight into the features feels a bit sudden, especially if I was a new user. I'd suggest adding a short description as the first section
- "Manage conversation settings" being the first section seems rather technical, it could be the last one, with a more simple section like the "Format messages" section as the first one
Other than that, some wording changes:
- "markdown syntax" --> "Markdown syntax" (capital M)
- Smart picker section --> Simply type "/" or go to the "+" menu to open the Smart Picker where you can attach various content to your messages. You can configure the Smart Picker to be able to add items from Nextcloud apps, GIFs, map locations, AI generated content and much more.
- Attachments section --> Attach files from your Nextcloud Hub using the "+" button. Share items from Files, Collectives, Tables, Deck and more. Some apps even support interactive widgets, for example, the Text app
$user->getUID() | ||
); | ||
|
||
$this->avatarService->setAvatarFromEmoji($room, '💡', '0082c9'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly we could use the set primary color as the background for "Note to self" and "Let's get started"? But no strong opinion here, as I see it as a part of the Nextcloud branding if it's too blue
4246c95
to
4593dc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works good
4593dc0
to
0eaf74b
Compare
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
0eaf74b
to
b396a2f
Compare
Signed-off-by: Joas Schilling <[email protected]>
b396a2f
to
2825400
Compare
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
guest/sample
🏁 Checklist
docs/
has been updated or is not required