Resolves #19790, Provides Support for IAM Credentials

[cuppett]

Includes support for either leveraging environment variables passed to the PHP runtime or IAM instance profile present on the host being used. The default and first choice is still the parameter file as documented.

See also: Developer Guide -> Chaining Providers

[kesselb]

Thanks 👍

[cuppett]

Anything else needed from me here? Is there a way for me to re-launch/attempt the failing CI build (or is it a common failure)?

[kesselb]

Anything else needed from me here

I don't think so.

for me to re-launch/attempt the failing CI build

Rebase would be nice.

is it a common failure

Yes.

[cuppett]

Anything else needed from me here

I don't think so.

for me to re-launch/attempt the failing CI build

Rebase would be nice.

is it a common failure

Yes.

Thanks! Rebase done.

[MorrisJobke]

Rebased because we had some broken test on master today. Sorry for that.

[MorrisJobke]

Code looks good 👍

[MorrisJobke]

Let me rebase again and @rullzer will review later today.

[kesselb]

Psalm warnings looks like a false positive to me. Should work if we import the function use function GuzzleHttp\Promise\promise_for; and use it like

				return promise_for(
					new Credentials($key, $secret)
				);

[cuppett]

Psalm warnings looks like a false positive to me. Should work if we import the function use function GuzzleHttp\Promise\promise_for; and use it like

				return promise_for(
					new Credentials($key, $secret)
				);

I have that cleanup... squash and force push or add commit?

[rullzer]

Still works when running with minio!
Good stuff!

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[MorrisJobke]

I have that cleanup... squash and force push or add commit?

Both are fine ... @cuppett mind to send another PR ... it seems @rullzer merged too early 🙈

[MorrisJobke]

Psalm warnings looks like a false positive to me. Should work if we import the function use function GuzzleHttp\Promise\promise_for; and use it like

				return promise_for(
					new Credentials($key, $secret)
				);

Tested locally and both result in the problem. Let me add it to the warning list for now.

[MorrisJobke]

#22345