[Bug]: Sharing records are not deleted after a file/folder has been permanently deleted

[luka-nextcloud]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Right now, deleting a file/folder does not delete its corresponding sharing records. After a file/folder has been deleted, sharing records should also be deleted.

Steps to reproduce

1. Create a file/folder
2. Share the created file/folder
3. Permanently delete that file/folder
4. Check table oc_share
   Expect: It's sharing records deleted
   Actual: It's sharing records still exist

Expected behavior

Sharing records should also be removed from the oc_share table.

Nextcloud Server version

28

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

Reproducible on 28, 29, 30, master

[nickvergessen]

This would mean if you accidentally delete a file and restore it from the trashbin, all shares are still destructed.

If we rephrase

After a file/folder has been deleted, sharing records should also be deleted.

to

After a file/folder has been deleted and removed from the trashbin, sharing records should also be deleted.

it would work. But I somewhat expect that this is already the case.

[luka-nextcloud]

I agree that we should only remove sharing records after a file/folder has been permanently deleted. Now the sharing records still exist even after the permanent delete.

[nickvergessen]

This daily running job should clear them:

server/apps/files_sharing/lib/DeleteOrphanedSharesJob.php

Line 23 in 3810770

class DeleteOrphanedSharesJob extends TimedJob {

[XueSheng-GIT]

Does this daily job work as expected? Two weeks ago I had an issue with moving a share and finally found out that it was becaus of an orphaned share. After running occ sharing:delete-orphan-shares the issue was resolved.
Because this was an old share, I question whether this daily job is enough.

[luka-nextcloud]

• The DeleteOrphanedSharesJob and command sharing:delete-orphan-shares have different logic
  • The DeleteOrphanedSharesJob is searching in filecache for deleting orphaned shares. So, the orphaned shares will only be deleted after file/folder is permanently deleted from trash bin
  • The command sharing:delete-orphan-shares can detect the shares of trashed file/folder since it checks accessibility of share owner to the source file/folder using function RootFolder::getUserFolder()
• Should we consider to sync/merge logic between above functions?

[nickvergessen]

Should we consider to sync/merge logic between above functions?

🙈

I think we should have both available as OCC. for a regular background job we would need to make sure it scales good enough.

[luka-nextcloud]

I think we should have both available as OCC. for a regular background job we would need to make sure it scales good enough.

Does it mean to make another command which will run logic of DeleteOrphanedSharesJob? If so, we should rename both commands not to make users confused.