Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up reposettings (NR-219611) #79

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

kang-makes
Copy link
Contributor

Deprecation of reposettings because there is an organization level policy that forces branch protections.

Org level and repo level protections collided and broke the automatic releases. These policies are not needed anymore.

@kang-makes kang-makes requested a review from a team August 9, 2024 11:09
sigilioso
sigilioso previously approved these changes Aug 12, 2024
Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Thanks!

color: d876e3
description: Categorizes issue or PR as a support question.
replaces: [ kind/support, question ]
coreint-settings: &coreint-settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now it is already in the readme, but since we are leaving the unused config file here. Should we also add a comment for us to remember that this is not used anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair: #b18cada

@kang-makes kang-makes merged commit 70a5ce5 into main Aug 12, 2024
7 checks passed
@kang-makes kang-makes deleted the kang-makes/clean-up-reposettings branch August 12, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants