Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing #373

Closed
rahul-goel opened this issue Aug 27, 2024 · 1 comment
Closed

Tests failing #373

rahul-goel opened this issue Aug 27, 2024 · 1 comment

Comments

@rahul-goel
Copy link
Contributor

The test test_projection is failing for the current commit and the current release as well (1.3.0).

I'm getting this:

        torch.testing.assert_close(v_viewmats, _v_viewmats, rtol=1e-3, atol=1e-3)
        torch.testing.assert_close(v_quats, _v_quats, rtol=2e-1, atol=1e-2)
>       torch.testing.assert_close(v_scales, _v_scales, rtol=1e-1, atol=2e-1)
E       AssertionError: Tensor-likes are not close!
E       
E       Mismatched elements: 1 / 335355 (0.0%)
E       Greatest absolute difference: 0.7041703462600708 at index (20956, 1) (up to 0.2 allowed)
E       Greatest relative difference: 1.711435079574585 at index (20956, 1) (up to 0.1 allowed)

tests/test_basic.py:264: AssertionError
========================================================================================================== warnings summary ==========================================================================================================
tests/test_basic.py::test_quat_scale_to_covar_preci[False]
tests/test_basic.py::test_rasterize_to_pixels[3]
  /home/rg/miniconda3/envs/nerfacc/lib/python3.9/site-packages/torch/utils/cpp_extension.py:1967: UserWarning: TORCH_CUDA_ARCH_LIST is not set, all archs for visible cards are included for compilation. 
  If this is not desired, please set os.environ['TORCH_CUDA_ARCH_LIST'].
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================================================================================== short test summary info =======================================================================================================
FAILED tests/test_basic.py::test_projection[True-True-False] - AssertionError: Tensor-likes are not close!
jckhng added a commit to jckhng/gsplat that referenced this issue Sep 3, 2024
@jckhng
Copy link
Contributor

jckhng commented Sep 3, 2024

test_projection is multiplying by radii instead of being using the valid variable as a mask. This is probably why the tests are failing. I have submitted a pull request #383 to fix the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants