Add Selene linter

[lithammer]

https://github.com/Kampfkarren/selene

[mjlbach]

@lithammer would you mind rebasing this and seeing how bad the damage is/what we would have to change? Last time I remember a lotttt of red.

[mjlbach]

are you psychic, I literally just opened this PR to rebase it haha

[lithammer]

Hah! Gotta find a reason to not work 😉 Anyway, seems like it doesn't have much to complain about anymore. Just some unused variables:

warning[unused_variable]: j is defined, but never used
   ┌─ lua/lspconfig/rust_analyzer.lua:28:30
   │
28 │         on_stdout = function(j, d, e)
   │                              ^

warning[unused_variable]: e is defined, but never used
   ┌─ lua/lspconfig/rust_analyzer.lua:28:36
   │
28 │         on_stdout = function(j, d, e)
   │                                    ^

warning[unused_variable]: j is defined, but never used
   ┌─ lua/lspconfig/rust_analyzer.lua:31:30
   │
31 │         on_stderr = function(j, d, e)
   │                              ^

warning[unused_variable]: e is defined, but never used
   ┌─ lua/lspconfig/rust_analyzer.lua:31:36
   │
31 │         on_stderr = function(j, d, e)
   │                                    ^

warning[unused_variable]: s is defined, but never used
    ┌─ lua/lspconfig/util.lua:189:23
    │
189 │     local function it(s, v)
    │                       ^

[mjlbach]

Andddd we should probably fix those And I did fix those :) . Can we move the selene config files out of the top level of the repo and then add the selene lint to make lint?

[lithammer]

Can we move the selene config files out of the top level of the repo

A downside with that is it will break editor integration. But I'm fine either way.

[...] and then add the selene lint to make lint?

It should already be there. Or were you thinking of something else?

[mjlbach]

A downside with that is it will break editor integration. But I'm fine either way.

You made this point in the neovim core formatting check too, but this time I concede :)

[lithammer]

A downside with that is it will break editor integration. But I'm fine either way.

You made this point in the neovim core formatting check too, but this time I conceed :)

Indeed! You win some, you lose some 🤷‍♂️

[mjlbach]

At this point I am amazed at the level of CI we have in the repo without implementing server specific tests 😆