ci: Remove lefthook path to make it accessible on Windows #12929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
requested changes
Jan 29, 2025
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
netroy
previously requested changes
Jan 29, 2025
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
tomi
approved these changes
Jan 30, 2025
n8n
|
||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ADO-2984-setup-template-credentials-list-fix
|
| Run status |
|
| Run duration | 04m 21s |
| Commit |
|
| Committer | Milorad FIlipović |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
365
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
39-projects.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Projects > when starting from scratch > should move resources between projects |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 26 specs in Cypress Cloud.
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove path on lefthook.yml to allow it to be accessible with windows
To test: change a typeScript file, save and run git commit command on Windows
Note to reviewer: Please test on Linux/mac to confirm it doesn't block them
Related Linear tickets, Github issues, and Community forum posts
None
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)