Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix OffscreenCanvas Support in WebGL #29867

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

Description
The OffscreenCanvas support was broken in the WebGLBackend with #27463. This PR fixes the issue.
image

This contribution is funded by Utsubo

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.37
79.06
339.37
79.06
+0 B
+0 B
WebGPU 477.43
132.37
477.54
132.4
+110 B
+29 B
WebGPU Nodes 476.9
132.25
477.01
132.28
+110 B
+31 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.82
112.02
464.82
112.02
+0 B
+0 B
WebGPU 546.47
148.04
546.58
148.07
+110 B
+31 B
WebGPU Nodes 502.35
137.74
502.46
137.76
+110 B
+27 B

@RenaudRohlinger RenaudRohlinger added this to the r171 milestone Nov 12, 2024
@sunag sunag merged commit 901c516 into mrdoob:dev Nov 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants