feat: improve telegram setup workflow (#6734)

Author: asbiin

app/Domains/Settings/ManageNotificationChannels/Web/Controllers/TelegramWebhookController.php

@@ -29,12 +29,13 @@ public function store(Request $request)
         // check if the message matches the expected pattern.
         // if the message does not match the pattern, then we return a 202 response
         // so telegram will stop trying to send the message.
-        if (! Str::of($messageText)->test('/^\/start\s[A-Za-z0-9-]{36}$/')) {
+        $message = Str::of($messageText);
+        if (! $message->test('/^\/start\s[A-Za-z0-9-]{36}$/')) {
             return response('Accepted', 202);
         }
 
         // Cleanup the string
-        $verificationKey = Str::of($messageText)->remove('/start ')->rtrim();
+        $verificationKey = $message->remove('/start ')->rtrim();
 
         // Get Telegram ID from the request.
         $chatId = $request->message['chat']['id'];

app/Domains/Settings/ManageNotificationChannels/Web/ViewHelpers/NotificationsIndexViewHelper.php

@@ -28,7 +28,7 @@ public static function data(User $user): array
             'emails' => $emailsCollection,
             'telegram' => [
                 'data' => $telegram ? self::dtoTelegram($telegram) : null,
-                'telegram_env_variable_set' => config('services.telegram-bot-api.token'),
+                'telegram_env_variable_set' => config('services.telegram-bot-api.token') !== null,
             ],
             'url' => [
                 'settings' => route('settings.index'),

lang/bn.json

@@ -826,6 +826,7 @@
     "Set as favorite": "প্রিয় হিসাবে সেট করুন",
     "Settings": "সেটিংস",
     "Settle": "মীমাংসা",
+    "Setup": "সেটআপ",
     "Setup Key": "সেটআপ কী",
     "Setup Key:": "সেটআপ কী:",
     "Setup Telegram": "টেলিগ্রাম সেটআপ করুন",

lang/ca.json

@@ -826,6 +826,7 @@
     "Set as favorite": "Estableix com a favorit",
     "Settings": "Configuració",
     "Settle": "Resoldre",
+    "Setup": "Configuració",
     "Setup Key": "Clau de configuració",
     "Setup Key:": "Clau de configuració:",
     "Setup Telegram": "Configura Telegram",

lang/da.json

@@ -826,6 +826,7 @@
     "Set as favorite": "Indstil som favorit",
     "Settings": "Indstillinger",
     "Settle": "Afregne",
+    "Setup": "Opsætning",
     "Setup Key": "Opsætningsnøgle",
     "Setup Key:": "Opsætningsnøgle:",
     "Setup Telegram": "Opsætning af telegram",

lang/de.json

@@ -826,6 +826,7 @@
     "Set as favorite": "Als Favorit festlegen",
     "Settings": "Einstellungen",
     "Settle": "Abwickeln",
+    "Setup": "Aufstellen",
     "Setup Key": "Einrichtungsschlüssel",
     "Setup Key:": "Setup-Schlüssel:",
     "Setup Telegram": "Telegram einrichten",

lang/el.json

@@ -826,6 +826,7 @@
     "Set as favorite": "Ορίστε ως αγαπημένο",
     "Settings": "Ρυθμίσεις",
     "Settle": "Εγκαθίσταμαι",
+    "Setup": "Ρύθμιση",
     "Setup Key": "Κλειδί ρύθμισης",
     "Setup Key:": "Κλειδί ρύθμισης:",
     "Setup Telegram": "Ρύθμιση Telegram",

lang/es.json

@@ -826,6 +826,7 @@
     "Set as favorite": "Establecer como favorito",
     "Settings": "Configuraciones",
     "Settle": "Pagar",
+    "Setup": "Configuración",
     "Setup Key": "Clave de configuración",
     "Setup Key:": "Clave de configuración:",
     "Setup Telegram": "Configurar Telegram",

lang/fr.json

@@ -826,6 +826,7 @@
     "Set as favorite": "Définir comme favori",
     "Settings": "Paramètres",
     "Settle": "Régler",
+    "Setup": "Configurer",
     "Setup Key": "Clé de configuration",
     "Setup Key:": "Clé de configuration :",
     "Setup Telegram": "Configurer Telegram",
@@ -1277,4 +1278,4 @@
     "😩 Awful": "😩 Horrible",
     "😶‍🌫️ Neutral": "😶‍🌫️ Neutre",
     "🥳 Awesome": "🥳 Génial"
-}
+}

lang/he.json

@@ -826,6 +826,7 @@
     "Set as favorite": "הגדר כמועדף",
     "Settings": "הגדרות",
     "Settle": "לִשְׁקוֹעַ",
+    "Setup": "להכין",
     "Setup Key": "מפתח הגדרה",
     "Setup Key:": "מפתח הגדרה:",
     "Setup Telegram": "הגדרת טלגרם",