Skip to content

Commit 0f636e4

Browse files
authored
fix: fix contact tags count (#6994)
1 parent 3ecf57b commit 0f636e4

File tree

4 files changed

+16
-13
lines changed

4 files changed

+16
-13
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ jobs:
250250

251251
# Test
252252
- name: Upgrade Chrome Driver
253-
run: php artisan dusk:chrome-driver $(google-chrome -version | awk '{ print $3 }' | cut -d . -f 1)
253+
run: php artisan dusk:chrome-driver --detect
254254
- name: Start Chrome Driver
255255
run: |
256256
chmod -R 0755 vendor/laravel/dusk/bin/

app/Http/Controllers/ContactsController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ private function contacts(Request $request, bool $active)
8585
}
8686

8787
$tagsCount = Tag::contactsCount();
88-
$contactsWithoutTagsCount = $contacts->doesntHave('tags')->count();
89-
88+
$contactsWithoutTagsCount = (clone $contacts)->doesntHave('tags')->count();
89+
9090
$tags = null;
9191
$url = null;
9292
$count = 1;

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"barryvdh/laravel-debugbar": "^3",
6767
"fakerphp/faker": "^1.10",
6868
"khanamiryan/qrcode-detector-decoder": "^2.0",
69-
"laravel/dusk": "^7.0",
69+
"laravel/dusk": "^7.11",
7070
"laravel/legacy-factories": "^1.0",
7171
"laravel/tinker": "^2.6",
7272
"matthiasnoback/live-code-coverage": "^1",

composer.lock

Lines changed: 12 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)