Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gh-repo-stats #44

Merged
merged 1 commit into from
May 3, 2023
Merged

Update gh-repo-stats #44

merged 1 commit into from
May 3, 2023

Conversation

andyfeller
Copy link
Contributor

closes #43

@andyfeller andyfeller requested a review from katiem0 May 2, 2023 21:16
@andyfeller andyfeller requested a review from a team as a code owner May 2, 2023 21:16
@andyfeller andyfeller self-assigned this May 2, 2023
katiem0
katiem0 approved these changes May 2, 2023
View reviewed changes
Copy link

@katiem0 katiem0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍🏻 Confirmed/tested that this fixes the issue for grabbing all data from repos with more than 1 page, and no errors received in output.

@andyfeller andyfeller merged commit 8e72b79 into main May 3, 2023
@andyfeller andyfeller deleted the issue-43-invalid-endcursor-field branch May 3, 2023 14:26
Zorbey99
Zorbey99 reviewed Jun 19, 2023
View reviewed changes
Copy link

@Zorbey99 Zorbey99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh-repo-stats

@Zorbey99
Copy link

gh-repo-stats

@Zorbey99
Copy link

gh-repo-stats

@Zorbey99
Copy link

Approved 👍🏻 Confirmed/tested that this fixes the issue for grabbing all data from repos with more than 1 page, and no errors received in output.

@andyfeller
Copy link
Contributor Author

@Zorbey99 : Could you help me understand the purpose behind the comments above, given that this pull request has been merged?

Zorbey99
Zorbey99 reviewed Jun 19, 2023
View reviewed changes
Copy link

@Zorbey99 Zorbey99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyfeller

@andyfeller
Copy link
Contributor Author

@Zorbey99 : As you might have noticed, #48 is discussing the adoption of a code of conduct in order to set healthy expectations for repository contributors and maintainers. It is clear this behavior does not fall under behavior for a professional environment. Further activity like this may result in consequences such as ban or reporting to GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zorbey99 Zorbey99 Zorbey99 left review comments

@katiem0 katiem0 katiem0 approved these changes

Assignees

@andyfeller andyfeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix breaking GraphQL query due to invalid field
3 participants
@andyfeller @Zorbey99 @katiem0