Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Version Detection & Support 2.21.7 #24

Merged
merged 12 commits into from
Jun 1, 2022
Merged

Add Version Detection & Support 2.21.7 #24

merged 12 commits into from
Jun 1, 2022

Conversation

samueljmello
Copy link

Attempting to detect version and exit when version is less than 2.20 (GraphQL endpoints were introduced then).

Also adding support for 2.20 and 2.21 as the isEmpty property did not exist yet.

@samueljmello samueljmello requested a review from a team as a code owner May 31, 2022 19:49
bryantson
bryantson approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@bryantson bryantson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve for now, but we should include a mechanism to include custom tests

gh-repo-stats Show resolved Hide resolved
@bryantson bryantson merged commit b2be5ee into main Jun 1, 2022
@bryantson bryantson deleted the samueljmello/add-version-detection branch June 1, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantson bryantson bryantson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samueljmello @bryantson