-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update runpod.sh #9
Conversation
Added comments to the code and changed a line that was causing me errors (the script would not upload the results to my gists when I run it manually and not from the google colab notebook).
# Run another Python script to upload the results as a GitHub gist. | ||
python ../main.py . $(($end-$start)) | ||
### Note: I changed this and this resolved the error of the results not uploading. | ||
### from: ../llm-evaluation/main.py . $(($end-$start)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm I don't remember why I did that haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems unnecessary as you only cd into the cloned repository so cd ../ should always work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I probably had a good reason back then but it's ugly so happy to change that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it breaks the script from uploading your results if you run it manually and not from within your notebook (which does work as is).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok ok
--output_path ./${benchmark}.json | ||
|
||
benchmark="gpt4all" | ||
python main.py \ | ||
--model hf-causal \ | ||
--model_args pretrained=$MODEL,trust_remote_code=$TRUST_REMOTE_CODE \ | ||
--model_args pretrained=$MODEL,trust_remote_code=$TRUST_REMOTE_CODE \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad :p
else | ||
echo "Error: Invalid BENCHMARK value. Please set BENCHMARK to 'nous' or 'openllm'." | ||
fi | ||
|
||
# If not in debug mode, remove the pod using the RUNPOD_POD_ID environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like GPT :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought you liked LLM's
# Run another Python script to upload the results as a GitHub gist. | ||
python ../main.py . $(($end-$start)) | ||
### Note: I changed this and this resolved the error of the results not uploading. | ||
### from: ../llm-evaluation/main.py . $(($end-$start)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I probably had a good reason back then but it's ugly so happy to change that
# Run another Python script to upload the results as a GitHub gist. | ||
python ../main.py . $(($end-$start)) | ||
### Note: I changed this and this resolved the error of the results not uploading. | ||
### from: ../llm-evaluation/main.py . $(($end-$start)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok ok
Added comments to the code and changed a line that was causing me errors (the script would not upload the results to my gists when I run it manually and not from the google colab notebook).