Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runpod.sh #9

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Update runpod.sh #9

merged 1 commit into from
Jan 29, 2024

Conversation

CultriX-Github
Copy link
Contributor

Added comments to the code and changed a line that was causing me errors (the script would not upload the results to my gists when I run it manually and not from the google colab notebook).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added comments to the code and changed a line that was causing me errors (the script would not upload the results to my gists when I run it manually and not from the google colab notebook).
# Run another Python script to upload the results as a GitHub gist.
python ../main.py . $(($end-$start))
### Note: I changed this and this resolved the error of the results not uploading.
### from: ../llm-evaluation/main.py . $(($end-$start))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm I don't remember why I did that haha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems unnecessary as you only cd into the cloned repository so cd ../ should always work.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I probably had a good reason back then but it's ugly so happy to change that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it breaks the script from uploading your results if you run it manually and not from within your notebook (which does work as is).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ok

--output_path ./${benchmark}.json

benchmark="gpt4all"
python main.py \
--model hf-causal \
--model_args pretrained=$MODEL,trust_remote_code=$TRUST_REMOTE_CODE \
--model_args pretrained=$MODEL,trust_remote_code=$TRUST_REMOTE_CODE \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad :p

else
echo "Error: Invalid BENCHMARK value. Please set BENCHMARK to 'nous' or 'openllm'."
fi

# If not in debug mode, remove the pod using the RUNPOD_POD_ID environment variable.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like GPT :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought you liked LLM's

# Run another Python script to upload the results as a GitHub gist.
python ../main.py . $(($end-$start))
### Note: I changed this and this resolved the error of the results not uploading.
### from: ../llm-evaluation/main.py . $(($end-$start))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I probably had a good reason back then but it's ugly so happy to change that

# Run another Python script to upload the results as a GitHub gist.
python ../main.py . $(($end-$start))
### Note: I changed this and this resolved the error of the results not uploading.
### from: ../llm-evaluation/main.py . $(($end-$start))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ok

@mlabonne mlabonne merged commit 8bc3f24 into mlabonne:master Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants