This repository has been archived by the owner on Apr 20, 2024. It is now read-only.
Allow parameterized queries on RawSQLBuilder #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steffendsommer Do you have time to take a look? 😄 |
| @@ -34,6 +34,18 @@ public class RawSQLBuilder<Database, Result> where | |||
|
|
|||
| self.sqlRawCountBuilder = connection.raw(countQuery) | |||
| } | |||
|
|
|||
| public func bind(_ encodable: Encodable) -> Self { | |||
| _ = sqlRawBuilder.bind(encodable) | |||
There was a problem hiding this comment.
Can the _ = be avoided? Otherwise LGTM
There was a problem hiding this comment.
I just looked at it and it's just because bind on SQLRawBuilder is defined as public func bind(_ encodable: Encodable) -> Self {. It could be avoided like this:
public func bind(_ encodable: Encodable) -> Self {
sqlRawBuilder.binds.append(encodable)
sqlRawCountBuilder?.binds.append(encodable)
return self
}But that's really doing the same thing. So 👍 from me too 🙂
steffendsommer
approved these changes
Oct 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to call
.bindsand.bindon a RawSQLBuilder object in order to support parameterized queries.