vscode://file// links no longer working

[jonsterling]

Type: Bug

All of a sudden, vscode://file// links are no longer working.

Expected behavior:

I click open a link like vscode://file//path-to-a-file-that-really-exists and it then VS Code opens the file. This has always worked for me.

Actual behavior:

I click open a link like vscode://file//path-to-a-file-that-really-exists and it then VS Code becomes focused, but it does not open the desired file.

Please note that I have verified that the file really does exist in the specified path.

VS Code version: Code 1.84.0 (Universal) (d037ac0, 2023-11-01T11:30:19.406Z)
OS version: Darwin arm64 23.0.0
Modes:

System Info

Item	Value
CPUs	Apple M1 (8 x 24)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	3, 3, 3
Memory (System)	16.00GB (0.14GB free)
Process Argv	--disable-extensions --crash-reporter-id f43891bf-1e90-4f74-a11c-73425109d857
Screen Reader	no
VM	0%

Extensions disabled

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30880072
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
282f8724:30602487
89544117:30613380
2i9eh265:30646982
showlangstatbar:30737416
03d35959:30757346
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30869155
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixtcf:30871695
pythonregdiag2:30871582
pythonmypyd1:30879173
pythoncet0:30874138
pythontbext0:30879054

[jonsterling]

To add more confusion to things, after ten minutes of behaving the way I described, VS Code started correctly opening these links. There must be some kind of intermittent bug, but I don't know how to reproduce it. Let me know if you have anything you'd like me to try on my machine.

[bpasero]

@jonsterling we did change something in that area, see https://code.visualstudio.com/updates/v1_84#_confirmation-for-opening-protocol-links

I wonder why you would not see a dialog opening. Do you have VS Code running with no window opened maybe?

A similar issue was reported in #197263

[BernhardBaumrock]

waa. same here! I get the dialog that asks me to confirm to open the link in vscode but then vscode flickers once and does nothing. this is really an issue for me so I'd be grateful for a quick fix 🤯

[bpasero]

I need to know if everyone sees the dialog and then it does not work or if some people do not see the dialog and some do and then it still does not work?

[bpasero]

Also, can people try to reproduce in insiders?

[jonsterling]

For what it’s worth, i think i did not see the dialog.  On Nov 3, 2023, at 5:47 PM, Benjamin Pasero ***@***.***> wrote: I need to know if everyone sees the dialog and then it does not work or if some people do not see the dialog and some do and then it still does not work? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[bpasero]

Please see if you can find any logged output that could help us find the source of the issue:

• run code --verbose from the command line
• reproduce the issue
• attach the log files you find from running the command "Open Logs Folder"

Thanks!

[bpasero]

I just realised: URLs of the form vscode://file//Users/bpasero/Desktop/test-js/package.json are not valid. They have to be vscode://file/Users/bpasero/Desktop/test-js/package.json, so I think this issue is addressable by making sure the URL is valid.