Skip to content

Ensure debugged program is terminated when Stop debugging button is clicked #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018

Conversation

DonJayamanne
Copy link

Fixes #1345

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)

@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #1739 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1739      +/-   ##
==========================================
+ Coverage   73.56%   73.69%   +0.13%     
==========================================
  Files         279      279              
  Lines       13060    13060              
  Branches     2328     2328              
==========================================
+ Hits         9607     9624      +17     
+ Misses       3314     3304      -10     
+ Partials      139      132       -7
Impacted Files Coverage Δ
src/client/debugger/Main.ts 52.34% <0%> (+0.49%) ⬆️
src/client/debugger/mainV2.ts 78.71% <0%> (+0.8%) ⬆️
src/client/debugger/PythonProcess.ts 51.25% <0%> (+5.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9022527...13dfe18. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 386df1f into microsoft:master May 24, 2018
@DonJayamanne DonJayamanne deleted the issue1345StopDebugger branch June 20, 2018 03:13
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python Experimental: code will still run after stop debugging
2 participants