Skip to content

Insiders build of the extension depends on unpackaged files #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
patrys opened this issue Apr 4, 2018 · 2 comments · Fixed by #1312
Closed

Insiders build of the extension depends on unpackaged files #1292

patrys opened this issue Apr 4, 2018 · 2 comments · Fixed by #1312
Assignees
@MikhailArkhipov
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
April 2018

Comments

@patrys
Copy link

patrys commented Apr 4, 2018

The nightly build tries to import ../test/constants from client/extension.js but the client/test dir is not part of the distribution.
@DonJayamanne
Copy link

@MikhailArkhipov Please could you look into this. Should be a simple fix.
@patrys Thanks for pointing this out.

@DonJayamanne DonJayamanne added this to the April 2018 milestone Apr 4, 2018
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR labels Apr 4, 2018
@MikhailArkhipov
Copy link

Yeah, it imports IS_ANALYSIS_ENGINE_TEST

@MikhailArkhipov MikhailArkhipov mentioned this issue Apr 5, 2018
Merged
2 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikhailArkhipov MikhailArkhipov

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
April 2018
Development

Successfully merging a pull request may close this issue.

Fix indentation on single-liners and f-strings in type formatting
3 participants
@patrys @DonJayamanne @MikhailArkhipov