Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Cascadia Code with the Terminal (release builds) #2806

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

DHowett-MSFT
Copy link
Contributor

@cinnamon-msft
Copy link
Contributor

Just to confirm, the font installs on download?

@DHowett-MSFT
Copy link
Contributor Author

The font installs when the package is installed. The font is removed when the package is removed. When you want to uninstall the font, you must remove the package (!)

@DHowett-MSFT
Copy link
Contributor Author

For all intents and purposes, the font is the package.

@cinnamon-msft
Copy link
Contributor

So if you don't want the font, you have to uninstall the Terminal package?

@DHowett-MSFT
Copy link
Contributor Author

you have to uninstall

Yes.

@zadjii-msft
Copy link
Member

Out of curiosity, what happens when I install Cascadia.ttf separately? Does the package install a second copy? If I remove Cascadia.ttf, but leave the package, is the font still installed? If I remove the package but not the ttf, does it stay installed?

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to somehow track which microsoft/cascadia-code commit is the one in our package?

@DHowett-MSFT
Copy link
Contributor Author

This one in particular requires @cinnamon-msft to sign off.

@cinnamon-msft
Copy link
Contributor

Out of curiosity, what happens when I install Cascadia.ttf separately? Does the package install a second copy? If I remove Cascadia.ttf, but leave the package, is the font still installed? If I remove the package but not the ttf, does it stay installed?

Did we test this scenario? I'd assume the TTF would persist but I'm not sure.

@miniksa
Copy link
Member

miniksa commented Sep 19, 2019

I'm concerned that people are already asking for this as a standalone Windows Store package (microsoft/cascadia-code#39) and that bundling it inside the Terminal package would create a conflict with that or multiple entries.

Are we going to distribute it this way "for a limited time" until we figure out how to release it standalone and maybe request it as a dependency/download when you install the Terminal package?

Or do we always intend to ship a copy of it inside the Terminal package?

@DHowett-MSFT
Copy link
Contributor Author

@miniksa this is temporary until we can add a dependency on the official package.
@cinnamon-msft yes, the ttf persists and the terminal can be uninstalled. i think the ttf version wins when both are installed. I'm not sure.

@DHowett-MSFT DHowett-MSFT merged commit b84a073 into master Sep 19, 2019
@DHowett-MSFT DHowett-MSFT deleted the dev/duhowett/fontface branch September 19, 2019 23:35
@ghost
Copy link

ghost commented Sep 24, 2019

🎉Windows Terminal Preview v0.5.2661.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants