-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package Cascadia Code with the Terminal (release builds) #2806
Conversation
TTF from microsoft/[email protected]
Just to confirm, the font installs on download? |
The font installs when the package is installed. The font is removed when the package is removed. When you want to uninstall the font, you must remove the package (!) |
For all intents and purposes, the font is the package. |
So if you don't want the font, you have to uninstall the Terminal package? |
Yes. |
Out of curiosity, what happens when I install Cascadia.ttf separately? Does the package install a second copy? If I remove Cascadia.ttf, but leave the package, is the font still installed? If I remove the package but not the ttf, does it stay installed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to somehow track which microsoft/cascadia-code commit is the one in our package?
This one in particular requires @cinnamon-msft to sign off. |
Did we test this scenario? I'd assume the TTF would persist but I'm not sure. |
I'm concerned that people are already asking for this as a standalone Windows Store package (microsoft/cascadia-code#39) and that bundling it inside the Terminal package would create a conflict with that or multiple entries. Are we going to distribute it this way "for a limited time" until we figure out how to release it standalone and maybe request it as a dependency/download when you install the Terminal package? Or do we always intend to ship a copy of it inside the Terminal package? |
@miniksa this is temporary until we can add a dependency on the official package. |
🎉 Handy links: |
TTF from microsoft/cascadia-code@5f91b87