Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search pane doesn't appear when Windows 10 is running on High Contrast #4393

Closed
warnov opened this issue Jan 29, 2020 · 3 comments · Fixed by #4406
Closed

Search pane doesn't appear when Windows 10 is running on High Contrast #4393

warnov opened this issue Jan 29, 2020 · 3 comments · Fixed by #4406
Labels
Area-Accessibility Issues related to accessibility Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@warnov
Copy link

warnov commented Jan 29, 2020

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.592]
Windows Terminal version (if applicable): 0.8

Any other software?

Steps to reproduce

Change the Windows theme to High Contrast (black). Open Windows Terminal. Press the shortcut assigned to the Find command. Notice that the search pane won't appear. Changing back the theme out from High Contrast, and pressing the the shortcut assigned to the Find command will make the search pane appear correctly.

Expected behavior

Changing the Windows theme to High Contrast (black) should allow to still having access to the search pane.

Actual behavior

Changing the Windows theme to High Contrast (black) is not allowing to have access to the search pane.

When you press the key shortcut assigned to the Find command it is not being shown. Nothing happens.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 29, 2020
@DHowett-MSFT
Copy link
Contributor

Wow. Yeah, that's bad.

@DHowett-MSFT DHowett-MSFT added Area-Accessibility Issues related to accessibility Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 29, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 29, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Jan 29, 2020
DHowett-MSFT pushed a commit that referenced this issue Jan 30, 2020
@DHowett
Fix the search box in High Contrast by using the right theme resources
f9697dd 
Fixes #4393.
@DHowett-MSFT DHowett-MSFT mentioned this issue Jan 30, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Jan 30, 2020
@ghost ghost closed this as completed in #4406 Jan 30, 2020
ghost pushed a commit that referenced this issue Jan 30, 2020
@DHowett
Fix the search box in High Contrast by using the right theme resources (
5c5471a 
#4406)

We were overriding the button foreground and the placeholder foreground using our
own custom resource names. They didn't exist in HC.

Instead of making them exist in HC, I made us use and override the real resource
names. Those ones have HC colors defined by the platform!

Fixes #4393.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 30, 2020
@ghost
Copy link

ghost commented Feb 13, 2020

🎉This issue was addressed in #4406, which has now been successfully released as Windows Terminal Preview v0.9.433.0.:tada:

Handy links:

@warnov
Copy link
Author

warnov commented Feb 15, 2020 •
edited
Loading

Awesome!! Thanks a lot guys for the good work and for being inclusive with the ones that need HC mode to work better. 💯

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Fix the search box in High Contrast by using the right theme resources microsoft/terminal
2 participants
@warnov @DHowett-MSFT