Add support for short hex color codes (like #CCC)

[mikemaccana]

Windows 10.0.18908.0. Terminal Preview 0.4.2382.0

Using #CCC instead of #CCCCCC results in an unparsable settings file. Not a big deal but since most other places (eg browser devtools)) that take hex also take short codes, worth fixing.

Not sure re: HSLA etc but that's a separate issue.

[DHowett-MSFT]

Yeah, we should probably support this. The first thing, not the HSLA thing.

[kojoru]

Should be a few lines' worth of change around here, right?

terminal/src/types/utils.cpp

Lines 92 to 105 in c97cccb

	COLORREF Utils::ColorFromHexString(const std::string str)
	{
	THROW_HR_IF(E_INVALIDARG, str.size() < 7 || str.size() >= 8);
	THROW_HR_IF(E_INVALIDARG, str[0] != '#');
	std::string rStr{ &str[1], 2 };
	std::string gStr{ &str[3], 2 };
	std::string bStr{ &str[5], 2 };
	BYTE r = static_cast<BYTE>(std::stoul(rStr, nullptr, 16));
	BYTE g = static_cast<BYTE>(std::stoul(gStr, nullptr, 16));
	BYTE b = static_cast<BYTE>(std::stoul(bStr, nullptr, 16));
	return RGB(r, g, b);

Can I try and take a stab at it?

[zadjii-msft]

@kojoru go right ahead!

Bonus points if you add a test in here :)

[ghost]

🎉This issue was addressed in #2658, which has now been successfully released as Windows Terminal Preview v0.5.2661.0.:tada:

Handy links:

• Release Notes
• Store Download