Process package.json exports with auto-import provider #47092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
commented
Dec 9, 2021
| //// { "dependencies": { "mylib": "file:packages/mylib" } } | ||
|
|
||
| // @Filename: /packages/mylib/package.json | ||
| //// { "name": "mylib", "version": "1.0.0" } |
There was a problem hiding this comment.
The diff between this test and autoImportProvider7.ts demonstrates a bug fixed by no longer using resolveTypeReferenceDirective:
- //// { "name": "mylib", "version": "1.0.0", "main": "index.js", "types": "index" }
+ //// { "name": "mylib", "version": "1.0.0" }The test previously needed "types": "index" (required to have no extension) to work, due to a quirk of type reference directive resolution.
andrewbranch
commented
Dec 9, 2021
| } | ||
| } | ||
|
|
||
| return packageJsonInfo.resolvedEntrypoints = entrypoints || false; |
There was a problem hiding this comment.
Calling this function caches its results on the PackageJsonInfo, which itself is stored in the PackageJsonInfoCache which is part of the ModuleResolutionCache—open to suggestions for a cleaner place to put this if there are objections.
weswigham
reviewed
Dec 10, 2021
68f312c to
f18e95d
Compare
sandersn
reviewed
Dec 15, 2021
Co-authored-by: Nathan Shively-Sanders <[email protected]>
weswigham
reviewed
Jan 6, 2022
weswigham
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly changes the package.json auto-import provider’s resolution process. Previously it used
resolveTypeReferenceDirectivewith a fallback totryResolveJsModulefor JS projects. UsingresolveTypeReferenceDirectivewas close but not quite right, so this fixes a couple straight up bugs, and also gives us the opportunity to pull in all files specifically referenced by an export map so those can be offered as auto-imports too. (Files matching a pattern export aren’t pulled in.)Fixes #47009