Skip to content

Regressions of lib.d.ts #10695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
falsandtru opened this issue Sep 3, 2016 · 4 comments
Closed

Regressions of lib.d.ts #10695

falsandtru opened this issue Sep 3, 2016 · 4 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 2.0.3

Comments

@falsandtru
Copy link
Contributor

falsandtru commented Sep 3, 2016 •
edited
Loading

Must fix regressions such as #6500. We need to get other regressions investigated. #6500 is regressed now.
@kitsonk
Copy link
Contributor

kitsonk commented Sep 3, 2016

I suspect that some manual adjustments to the lib.d.ts were overwritten when migrating to/refreshing the ChakraCore interfaces, because for some reason .clear() is still there.

I raised an issue in chakra-core/ChakraCore#1539 to question why it was still in there.

@kitsonk kitsonk mentioned this issue Sep 3, 2016
Closed
@kitsonk
Copy link
Contributor

kitsonk commented Sep 3, 2016

It was stated that in the referenced ticket that .clear() is not exposed into the runtime, so I am not sure how the TSJS-lib-generator is picking it up (see: microsoft/TypeScript-DOM-lib-generator#145)

@falsandtru
Copy link
Contributor Author

It is certainly suspicious. Thanks for letting me know.

@zhengbli @DanielRosenwasser @mhegazy can you fix these regressions?

@mhegazy
Copy link
Contributor

mhegazy commented Sep 6, 2016

A PR would be appreciated.

@mhegazy mhegazy added the Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript label Sep 6, 2016
@mhegazy mhegazy added this to the Community milestone Sep 6, 2016
@mhegazy mhegazy added Help Wanted You can do this Bug A bug in TypeScript labels Sep 6, 2016
@zhengbli zhengbli mentioned this issue Sep 6, 2016
Merged
@zhengbli zhengbli added the Fixed A PR has been merged for this issue label Sep 6, 2016
@mhegazy mhegazy modified the milestones: TypeScript 2.0.3, Community Sep 6, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 2.0.3
Development

No branches or pull requests
4 participants
@zhengbli @kitsonk @falsandtru @mhegazy