Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify modified tags cleanup when exiting the dialog #2601

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Simplify modified tags cleanup when exiting the dialog #2601

merged 1 commit into from
Mar 10, 2025

Conversation

zas
Copy link
Collaborator

@zas zas commented Mar 10, 2025

  • use a generator for modified tags and their non-empty values
  • drop useless intermediate methods

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas zas requested a review from phw March 10, 2025 11:19
phw
phw requested changes Mar 10, 2025
View reviewed changes
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great catch that Metadata.update can be used directly.

@zas zas force-pushed the edittagdialog_refactor3 branch from d29c9fb to e5c0460 Compare March 10, 2025 11:30
@zas
Simplify modified tags cleanup when exiting the dialog
Loading
Loading status checks…
cc0aa33 
- use a generator for modified tags and their non-empty values
- drop useless intermediate methods
@zas zas force-pushed the edittagdialog_refactor3 branch from e5c0460 to cc0aa33 Compare March 10, 2025 11:33
phw
phw approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zas zas merged commit 3458411 into metabrainz:master Mar 10, 2025
50 checks passed
@zas zas deleted the edittagdialog_refactor3 branch March 10, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phw phw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zas @phw