-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/mem0 support es #2125
Feat/mem0 support es #2125
Conversation
pyproject.toml
Outdated
@@ -25,6 +25,7 @@ sqlalchemy = "^2.0.31" | |||
langchain-community = "^0.3.1" | |||
neo4j = "^5.23.1" | |||
rank-bm25 = "^0.2.2" | |||
elasticsearch = "^8.17.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to ideally install elasticsearch
in default installation. So can you please add something like this in file vector_stores/elasticsearch.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have addressed your review comments. Please check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey the changes looks good but we just have to remove this library from the poetry
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh,,.! I just changed it as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you add docs at docs/components/vectordbs
, you can take reference from other vectordbs or please let me know I can help you out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove elasticsearch
entirely from the pyproject
file and leave the poetry section as is. We'll make a few poetry-related updates in the upcoming PR.
Then we are good to go.
Okay, I entirely remove it. |
@alohays Can you please run |
I've done it already. Since es was in an optional poetry group, |
Cool @alohays Thanks for the contribution. I'll the poetry issue incase they arise. |
Description
Added comprehensive Elasticsearch integration as a new vector store option. This includes:
ElasticsearchConfig
class for configuration managementElasticsearchDB
class for vector operations (storing, retrieving, searching)Type of change
How Has This Been Tested?
Checklist:
Maintainer Checklist