Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(merkle tree): Use test-casing for Merkle tree tests #540

Merged
merged 1 commit into from
Nov 24, 2023
Merged

test(merkle tree): Use test-casing for Merkle tree tests #540

merged 1 commit into from
Nov 24, 2023

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Nov 24, 2023

What ❔

Structure tests in the Merkle tree crate using test-casing crate, since it's already used in the server codebase.

Why ❔

Makes tests more concise and makes it easier to cover more cases.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@slowli slowli marked this pull request as ready for review November 24, 2023 09:17
@slowli slowli requested a review from a team as a code owner November 24, 2023 09:17
@slowli slowli added this pull request to the merge queue Nov 24, 2023
Merged via the queue into main with commit 9ced921 Nov 24, 2023
@slowli slowli deleted the aov-bft-382-use-test-casing-crate-for-merkle-tree branch November 24, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montekki montekki montekki approved these changes

@RomanBrodetski RomanBrodetski Awaiting requested review from RomanBrodetski

@popzxc popzxc Awaiting requested review from popzxc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowli @montekki